Allow project name to come from X-IRI-Facility-Project header#91
Open
juztas wants to merge 7 commits into
Open
Allow project name to come from X-IRI-Facility-Project header#91juztas wants to merge 7 commits into
juztas wants to merge 7 commits into
Conversation
juztas
changed the title
pmrich
approved these changes
May 14, 2026
Contributor
pmrich
left a comment
pmrich
left a comment
There was a problem hiding this comment.
This looks fine to me at this point.
| status_code=400, | ||
| detail="Project/account must be specified in exactly one place: job_spec.attributes.account or X-IRI-Facility-Project.", | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
I believe this should be job_spec.attributes.account should override the header value. That should be documented.
Contributor
There was a problem hiding this comment.
Review withdwawn. This behavior is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.